-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quote message window content display and markdown issues #774
base: develop
Are you sure you want to change the base?
Conversation
You need not to show the content and video/ audio in the confirmation, due to markdown and size limit issue, it was earlier decided by Sidharth and us to avoid keeping those text.. Maybe, You can remove this change from here and raise another PR for that, we'll see if we can add that again |
Hey @Spiral-Memory text along with markdown was previously present in delete confirmation modal should I consider removing it too ? |
@Spiral-Memory I think you are not able to see the contents because markdown is taking an md prop after PR #677 , but the Markdown component in delete confirmation modal does not pass an md prop so its undefined hence <></> is rendered . |
If that's the case, maybe let it be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Brief Title
Acceptance Criteria fulfillment
md
prop for markdown components inside the delete modal and quote messages.Fixes #773
Video/Screenshots
Screencast.from.2025-01-02.22-10-23.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-774 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.