Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quote message window content display and markdown issues #774

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

abirc8010
Copy link
Contributor

@abirc8010 abirc8010 commented Jan 2, 2025

Brief Title

Acceptance Criteria fulfillment

  • Passed an md prop for markdown components inside the delete modal and quote messages.
  • Rendered Quote messages with markdown
  • Included message content inside the delete message modal.

Fixes #773

Video/Screenshots

Screencast.from.2025-01-02.22-10-23.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-774 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010 abirc8010 changed the title fix delete modal content and markdown issues fix: delete modal and quote message window content display and markdown issues Jan 2, 2025
@Spiral-Memory
Copy link
Collaborator

You need not to show the content and video/ audio in the confirmation, due to markdown and size limit issue, it was earlier decided by Sidharth and us to avoid keeping those text.. Maybe, You can remove this change from here and raise another PR for that, we'll see if we can add that again

@Spiral-Memory Spiral-Memory changed the title fix: delete modal and quote message window content display and markdown issues fix: quote message window content display and markdown issues Jan 5, 2025
@abirc8010
Copy link
Contributor Author

You need not to show the content and video/ audio in the confirmation, due to markdown and size limit issue, it was earlier decided by Sidharth and us to avoid keeping those text.. Maybe, You can remove this change from here and raise another PR for that, we'll see if we can add that again

Hey @Spiral-Memory text along with markdown was previously present in delete confirmation modal should I consider removing it too ?

@Spiral-Memory
Copy link
Collaborator

image
No it's not present ig

@abirc8010
Copy link
Contributor Author

abirc8010 commented Jan 5, 2025

@Spiral-Memory I think you are not able to see the contents because markdown is taking an md prop after PR #677 , but the Markdown component in delete confirmation modal does not pass an md prop so its undefined hence <></> is rendered .
image

@Spiral-Memory
Copy link
Collaborator

If that's the case, maybe let it be
I'll merge this PR

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quoted message content not displayed, and markdown not applied to quoted messages in chat window
2 participants