Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#468 user mention fixed #476

Merged

Conversation

umangutkarsh
Copy link
Contributor

@umangutkarsh umangutkarsh commented Feb 17, 2024

Brief Title

The PR fixes #468

Acceptance Criteria fulfillment / Issues addressed

  • The members of channel should be displayed in MembersList when mentioning users
  • Member list panel should be closed when message is sent.
  • 'all' and 'here' mention options should be there to mention all users of channel and all online users of channel respectively.
  • UI fixes
  • The mention user suggestion panel is not closed when invalid user-name is entered as is closed in rocket chat.
  • Enter key should send the message with mention.
  • Mention can be sent along with any message typed
  • Fixed selecting the members of channel from arrow-keys
  • Removed the mentionmemberStore since that became redundant as member list can be populated with useMemberStore and intializing some states.

Fixes #468

Video/Screenshots

mentions.webm
mentions-more.webm

@umangutkarsh
Copy link
Contributor Author

Will fix the linting errors

@umangutkarsh
Copy link
Contributor Author

Hi @abhinavkrin . Please review this.
Thanks.

@Spiral-Memory
Copy link
Collaborator

Great work bro @umangutkarsh

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @umangutkarsh !! LGTM

@sidmohanty11 sidmohanty11 merged commit 7caed56 into RocketChat:develop Feb 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Mention fixes
3 participants