Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#457]: Invite link appearance fixed/Copy to clipboard button added/Improvements in the slash command panel UI/Bug-fixes #475

Merged

Conversation

umangutkarsh
Copy link
Contributor

@umangutkarsh umangutkarsh commented Feb 17, 2024

Brief Title

This PR fixes ** Bug1 + Bug2 + Feature1** of issue: #457

Acceptance Criteria fulfillment

  • The invite link (for channel) button should not appear if the logged in user is not an admin.
  • A copy to clipboard button (for invite link) can be added to improve UX.
  • Pressing the enter key doesn't send the message with slash command.
  • Improve slash command panel
  • Unexpected error occurs when the invite link is selected and dragged.
  • Linting Errors fixed.

Addresses #457

Video/Screenshots

inv-issue.webm
slash-c.webm

@umangutkarsh
Copy link
Contributor Author

Hey @abhinavkrin , @sidmohanty11 . Please review this. Fixed some bugs, and added a minor feature.

Thanks

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had one question, should the invite link redirect the user to RC or the user's webpage where EC is embedded

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Feb 24, 2024

LGTM! I had one question, should the invite link redirect the user to RC or the user's webpage where EC is embedded

Thanks for reviewing the PR.
I have not really tried embedding EC on some other webpage. I usually use the docker image of RC to develop and test EmbeddedChat, and the link redirects to the RC.

@umangutkarsh umangutkarsh changed the title Fix/#457 bug fix/feature add Fix/#457 Invite-link-appearance-fixed/copy-to-clipboard-button-added/improvements-in-the-slash-command-panel-UI/Bug-fixes Mar 1, 2024
@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Mar 3, 2024

Hey @sidmohanty11 @abhinavkrin can you please review this PR?

Thanks

@umangutkarsh umangutkarsh changed the title Fix/#457 Invite-link-appearance-fixed/copy-to-clipboard-button-added/improvements-in-the-slash-command-panel-UI/Bug-fixes [Fix/#457]: Invite link appearance fixed/Copy to clipboard button added/Improvements in the slash command panel UI/Bug-fixes Mar 3, 2024
@umangutkarsh
Copy link
Contributor Author

Hey @sidmohanty11 @abhinavkrin can you please review this PR?

Thanks

Hi @sidmohanty11 can you please review this? Thanks

@sidmohanty11 sidmohanty11 merged commit b147288 into RocketChat:develop Mar 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants