-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed the app's behavior in read-only channels. #421
fix: fixed the app's behavior in read-only channels. #421
Conversation
6c95b92
to
e22cd7a
Compare
e22cd7a
to
1ff8962
Compare
1ff8962
to
35d95e0
Compare
Hey @abhinavkrin , I have made the required changes, and the PR is now ready for review. I am also attaching a video demonstrating the behavior of all possible permutations of non-private-non-read-only channels, non-private but read-only channels, private but not read-only channels, and both private and read-only channels. In all cases, the behavior is now appropriate, addressing all the issues I mentioned earlier. This PR deals with disabling writing to read-only channels if not permitted and showing the same info. Additionally, logout any user if the channel is private and they are not permitted, with a valid toast message. 2024-02-08.01-03-42.mp4Note: In the video, [email protected] is the authorized user and [email protected] is the unauthorized user. This is to demonstrate the functionality of the app. |
3e9feb1
to
0f67236
Compare
@Spiral-Memory Please resolve merge conflicts |
Yes Sure @abhinavkrin |
0f67236
to
863b01e
Compare
@abhinavkrin, I have resolved the conflicts, please check now. |
2c67bb1
to
2c73a17
Compare
added error info when no permission
2c73a17
to
571f128
Compare
* fixed read only channel issue added error info when no permission * formatted with prettier
Brief Title
Fixed the issue where, in read-only channels, users with posting permissions can now send messages as usual. However, those users without permission to post can still read messages but are restricted from sending messages to the group. They will be notified that the group is read-only, ensuring appropriate behavior.
Acceptance Criteria fulfillment
/api/v1/permissions.listAll.
getChannelRoles()
for the channel and determined the permissions of the logged-in user.Fixes #420
Video/Screenshots
2024-01-23.18-45-21.mp4
Note: This PR changes the backend code and requires a rebuild.