Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugs backstop.js implementation #768

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Debugs backstop.js implementation #768

merged 4 commits into from
Dec 5, 2024

Conversation

helrond
Copy link
Member

@helrond helrond commented Dec 4, 2024

  • Sets localStorage data
  • Adds mocks to additional scenarios
  • Adds missing requests

Backstop is still failing for a good number of snapshots, but in general it seems to be because of text spacing and other minor changes.

@helrond helrond requested a review from HaSistrunk December 4, 2024 23:24
HaSistrunk
HaSistrunk approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@HaSistrunk HaSistrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks so much for figuring this out! I closely reviewed and then updated the reference images. There are no unintended UI changes that I'm see.

@helrond helrond merged commit c8a4e55 into development Dec 5, 2024
1 check passed
@helrond helrond deleted the issue-738 branch December 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaSistrunk HaSistrunk HaSistrunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helrond @HaSistrunk