Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splines fixes #272

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Splines fixes #272

wants to merge 22 commits into from

Conversation

billwpierce
Copy link
Member

Adds sensordrive, fixes splines.

@billwpierce billwpierce requested a review from Daniel-E-B March 8, 2020 17:54
@billwpierce billwpierce self-assigned this Mar 8, 2020
Copy link
Member

@NikhilSuresh24 NikhilSuresh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we should uncomment and test some parts before merging

@@ -6,6 +6,7 @@
import org.usfirst.frc4904.standard.humaninput.Operator;
import edu.wpi.first.wpilibj.TimedRobot;
import edu.wpi.first.wpilibj2.command.CommandBase;
import edu.wpi.first.wpilibj2.command.InstantCommand;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Comment on lines +68 to +69
// try { // TODO: @Daniel-E-B uncomment and test
// motor.reset();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try this TODO before merging?

@b-cho b-cho changed the base branch from 2020-update to main February 10, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants