-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splines fixes #272
base: main
Are you sure you want to change the base?
Splines fixes #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we should uncomment and test some parts before merging
@@ -6,6 +6,7 @@ | |||
import org.usfirst.frc4904.standard.humaninput.Operator; | |||
import edu.wpi.first.wpilibj.TimedRobot; | |||
import edu.wpi.first.wpilibj2.command.CommandBase; | |||
import edu.wpi.first.wpilibj2.command.InstantCommand; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
// try { // TODO: @Daniel-E-B uncomment and test | ||
// motor.reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try this TODO
before merging?
Adds sensordrive, fixes splines.