SEVERE BUG IN LOGKITTEN -- INCORRECT LOGGING

[leijurv]

Leaving logMessage(Object message, KittenLevel level, boolean override) as public introduces a subtle bug.

private static String getLoggerMethodCallerMethodName() {
	return Thread.currentThread().getStackTrace()[4].getMethodName(); // caller of the logger method is fifth in the stack trace
}

This method gets the fifth item in the stack trace. Normally, a class calls, for example void f(Object message) { // Log fatal message, which then calls LogKitten.logMessage(message, KittenLevel.FATAL, false);. This results in the fifth item in the stack trace being, as expected, the function that calls LogKitten.

However, if logMessage were public, the fifth item in the stack trace would be the function that calls the function that calls logkitten, resulting in incorrect logging.

The levels of indirection in calling LogKitten must be standardized, otherwise logging of what function called LogKitten will be inconsistent.

[oldgalileo]

Please test and ensure that the logging format is the same. Then will merge.

[leijurv]

Logging will not be the same, that's the point. This changes the logging.

[leijurv]

can one of you guys that's merging all my PRs from literally two years ago glance at this? this is a legitimate bug.

[leijurv]

X calls Y calls LogKitten.warn. LogKitten says "Y had a warning"
X calls Y calls LogKitten.logMessage(warn). LogKitten says "X had a warning"

this is a giant foot-gun and could cause very hard to debug incorrect logging. there is one example currently. LogKitten.logMessage REALLY SHOULD be a private method.