Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/simple sensor simulator unit tests part3 #29

Open
wants to merge 7 commits into
base: feature/simple_sensor_simulator_unit_tests_part2
Choose a base branch
from

Conversation

SzymonParapura
Copy link

Description

Abstract

This PR contains unit tests for:

  1. DetectionSensor

Details

  1. update_unknownSubtype
  2. update_carSubtype
  3. update_truckSubtype
  4. update_busSubtype
  5. update_trailerSubtype
  6. update_motorcycleSubtype
  7. update_bicycleSubtype
  8. update_pedestrianSubtype
  9. update_detectionDelay
  10. update_looseAllData
  11. update_lidarBasedDetection

References

Jira ticket: link

Destructive Changes

There are no destructive changes

 - Added new line at the end of test_detection_sensor.hpp
@SzymonParapura SzymonParapura requested a review from robomic June 20, 2024 11:14
@SzymonParapura SzymonParapura self-assigned this Jun 20, 2024
Copy link

@robomic robomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove repeated functions if possible; in test_lidar_sensor.hpp and test_detection_sensor_hpp.

…feature/simple_sensor_simulator_unit_tests_part3
 - Refactored DetectionSensor tests
 - Refactored LidarSensor tests
@SzymonParapura SzymonParapura requested a review from robomic June 21, 2024 14:44
@SzymonParapura
Copy link
Author

I have refactored LidarSensor also...

Copy link

@robomic robomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SzymonParapura SzymonParapura requested a review from robomic June 26, 2024 11:10
 - Refactored TrafficLightDetector unit tests
Copy link

@robomic robomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants