Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw values #49

Closed
wants to merge 4 commits into from
Closed

Use raw values #49

wants to merge 4 commits into from

Conversation

cod3gen
Copy link

@cod3gen cod3gen commented Jan 31, 2024

May not be of interest, but the orginal setADC did not work good enough for me. Added setADCRaw which allows to use raw values, and included an async example of doing this like in ADS1X15.

@RobTillaart RobTillaart self-assigned this Jan 31, 2024
@RobTillaart
Copy link
Owner

Thanks for the improvement,
Will look into it later, possibly after weekend as I am quite busy

@RobTillaart
Copy link
Owner

The build-CI broke so I took time to look and your PR raises serious questions.

  • Q1: can you explain the goal you want to accomplish with the PR?
  • Q2: the new variable _raw is never set, how should this work?
  • Q3: the new variable _readADCRaw is set once in setADCRaw(), how should this work?
  • Q4: the new example does not transfer the raw reading from the ADS1115 to the ACS712, how should this work?

Q1 is the most important, as that gives the rationale why you wrote this PR.

@cod3gen
Copy link
Author

cod3gen commented Feb 1, 2024

Apparently, my head was not included yesterday. I have issues using the callback function with setADC inside a class, but what i have done here will never update the value.

@cod3gen cod3gen closed this Feb 1, 2024
@cod3gen cod3gen deleted the setadc branch February 1, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants