Update to NET8.0 #12
Open
Update to NET8.0 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 4, 2024 09:24
Nothing much changed, removed obsolete elements and removed castle build.
And some code cleaning
|
I'm not sure what the PR is meant for? It's (totally) fine and OK to create your own fork, but I hope you understand I can't merge a PR where the project name is changed, the Readme refers to it's (past) self, url's are changed to another (your forked) repository etc. 😅 |
|
No problem. You’re right of course. I can revert the namespace changes and create another PR. The namespace change was to make sure that my fork wouldn’t collide with your version, but it should not have been part of the PR.
…Sent from my iPhone
On 5 Dec 2024, at 17:56, Rob Janssen ***@***.***> wrote:
I'm not sure what the PR is meant for? It's (totally) fine and OK to create your own fork, but I hope you understand I can't merge a PR where the project name is changed, the Readme refers to it's (past) self, url's are changed to another (your forked) repository etc. 😅
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I migrated to net 8.0, updated the libraries and started to add some extra functionality so it can be added as a service using DI.