Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less flaky: test newest java only. use batch download (.github actions) #1797

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

less flaky: test newest java only. use batch download (.github actions) #1797

wants to merge 2 commits into from

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Nov 21, 2020 •
edited
Loading

Category

github workflow:

  • builds in batch mode
  • tests once on every platform, and at least once for java8 and java14. but not every java on every platform any more. this helps tests not beeing so flaky

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • [ x] a new feature

Description

Please add details about your change here.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@soloturn soloturn changed the title mvn -B talks less when downloading dependencies in check builds optimize .github workflow actions Nov 27, 2020
@soloturn
mvn -B talks less when downloading dependencies in check builds
637c3a3
@soloturn
one build is sufficient to test newest java
45059d3 
check builds are flaky, and doing them more often in a short
time frame makes them even more flaky.
@soloturn soloturn changed the title optimize .github workflow actions test on every platform and once newest java. use batch download (.github actions) Nov 29, 2020
@soloturn soloturn changed the title test on every platform and once newest java. use batch download (.github actions) less flaky: test newest java only. use batch download (.github actions) Nov 29, 2020
@soloturn
Copy link
Contributor Author

included here:
https://github.com/ripmeapp2/ripme/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soloturn