catch exceptions from registerProcessObserver and registerUidObserver

RikkaApps · Mar 27, 2019 · 366f305 · 366f305
1 parent 11156c6
commit 366f305
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/build.gradle b/build.gradle
@@ -33,7 +33,7 @@ task clean(type: Delete) {
 
 def gitCommitId = 'git rev-parse --short HEAD'.execute([], project.rootDir).text.trim()
 def gitCommitCount = Integer.parseInt('git rev-list --count HEAD'.execute([], project.rootDir).text.trim())
-def baseVersionName = '3.2.0'
+def baseVersionName = '3.2.1'
 
 ext {
     androidXLibraryVersion = '1.0.0'

diff --git a/server/src/main/java/moe/shizuku/server/BinderSender.java b/server/src/main/java/moe/shizuku/server/BinderSender.java
@@ -110,16 +110,24 @@ private static void onActive(int uid, int pid) throws RemoteException {
         }
     }
 
-    public static void register(ShizukuService shizukuService) throws RemoteException {
+    public static void register(ShizukuService shizukuService) {
         sShizukuService = shizukuService;
 
-        Api.registerProcessObserver(new ProcessObserver());
+        try {
+            Api.registerProcessObserver(new ProcessObserver());
+        } catch (Throwable tr) {
+            LOGGER.e(tr, "registerProcessObserver");
+        }
 
         if (Build.VERSION.SDK_INT >= 26) {
-            Api.registerUidObserver(new UidObserver(),
-                    ActivityManager.UID_OBSERVER_ACTIVE,
-                    ActivityManager.PROCESS_STATE_UNKNOWN,
-                    null);
+            try {
+                Api.registerUidObserver(new UidObserver(),
+                        ActivityManager.UID_OBSERVER_ACTIVE,
+                        ActivityManager.PROCESS_STATE_UNKNOWN,
+                        null);
+            } catch (Throwable tr) {
+                LOGGER.e(tr, "registerUidObserver");
+            }
         }
     }
 }
diff --git a/server/src/main/java/moe/shizuku/server/ShizukuService.java b/server/src/main/java/moe/shizuku/server/ShizukuService.java
@@ -48,11 +48,7 @@ public class ShizukuService extends IShizukuService.Stub {
             mToken = token.toString();
         }
 
-        try {
-            BinderSender.register(this);
-        } catch (RemoteException e) {
-            LOGGER.e(e, "registerProcessObserver");
-        }
+        BinderSender.register(this);
     }
 
     static Map<Integer, String> getPidToken() {