Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Devendored all deps #144

Merged
merged 16 commits into from
Jan 7, 2025
Merged

Conversation

AnotherFoxGuy
Copy link
Member

This PR removes the dependencies folder and replaces it with conan/the system package manager

@ohlidalp
Copy link
Member

ohlidalp commented Dec 15, 2024

Test result:

I got it to work, but some tweaks are needed:

Testing notes:

Windows 10 x64, Visual Studio 2022 Community, vsdevcmd arch=x64

Microsoft Windows [Version 10.0.19045.5247]
Python 3.13.0
pip 24.3.1 
Conan version 2.10.2
cmake version 3.31.2

The .cmd I launched in x64 Native Visual Studio Command Prompt:

conan remote add ror-conan https://git.anotherfoxguy.com/api/packages/rorbot/conan

cd %USERPROFILE%/hobby/source/ror-server
@set BUILDDIR=%USERPROFILE%/hobby/builds/ror-server

:: Install the deps with conan
conan install . -b missing -pr:b=tools/conan-profiles/vs-22-release -pr=tools/conan-profiles/vs-22-release -of %BUILDDIR%
conan install . -b missing -pr:b=tools/conan-profiles/vs-22-debug   -pr=tools/conan-profiles/vs-22-debug   -of %BUILDDIR%

:: Generate the VS project files
cmake -D="RORSERVER_WITH_ANGELSCRIPT=ON" --preset conan-default

pause

@ohlidalp
Copy link
Member

I tested using this build script:

conan remote add ror-conan https://git.anotherfoxguy.com/api/packages/rorbot/conan

cd %USERPROFILE%/hobby/source/ror-server
@set BUILDDIR=%USERPROFILE%/hobby/builds/ror-server

:: Install the deps with conan
conan profile detect --force
conan install . -b missing -of %BUILDDIR%
conan install . -b missing -of %BUILDDIR%

:: Generate the VS project files
cmake -D="RORSERVER_WITH_ANGELSCRIPT=ON" --preset conan-default

Both Debug and Release configuration work now, great!
However, before I merge I want the wiki build instructions updated, because a build with conan isn't at all intuitive.

@AnotherFoxGuy
Copy link
Member Author

However, before I merge I want the wiki build instructions updated, because a build with conan isn't at all intuitive.

Done: https://github.com/RigsOfRods/ror-server/wiki/Compiling-server

Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested on Win10, cmake version 3.31.2, Conan version 2.10.2, Python 3.13.0.

I followed the new wiki instructions precisely, except I set different build dir and absolute path to 'conan_provider.cmake' just to be sure.

Both Debug & Release work, AngelScript is enabled 👍

@ohlidalp ohlidalp merged commit 59bef02 into RigsOfRods:master Jan 7, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants