Stop gathering coverage and running danger because I did not set it u…

…p and do not have the time or energy to maintain it. If there is a simpler way to do this in future, we could consider adding it back.
Rightpoint · Dec 25, 2023 · d0a7abc · d0a7abc
1 parent 4857ad3
commit d0a7abc
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 347 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,59 +1,6 @@
 version: 2.1
 
 jobs:
-  danger:
-    executor: xcode-14
-    steps:
-      - setup
-      - run:
-          name: Install xchtmlreport
-          command: |
-            curl -O https://raw.githubusercontent.com/TitouanVanBelle/XCTestHTMLReport/develop/xchtmlreport.rb
-            brew install --HEAD --build-from-source xchtmlreport.rb
-      - run:
-          name: Install xcparse
-          when: always
-          command: |
-            brew install chargepoint/xcparse/xcparse
-      - run:
-          name: Tests & Code Coverage
-          when: always
-          command: |
-            bundle exec fastlane coverage_all
-      # Store xcov Code Coverage HTML report artifact
-      - store_artifacts:
-          path: build/BonMot-iOS/xcov
-          destination: xcov
-      - store_artifacts:
-          path: build/BonMot-iOS/slather
-          destination: slather
-      - store_artifacts:
-          path: build/BonMot-iOS/scan
-          destination: scan
-      - run:
-          name: Rename CircleCI JUnit XML
-          when: always
-          command: |
-            mkdir -p build/test-results/danger
-            cp build/BonMot-iOS/scan/BonMot-iOS.xcresult/report.junit build/test-results/danger/results.xml
-      - store_test_results:
-          path: build/test-results
-      # Install SwiftLint only before Danger because otherwise it fails the build
-      - run:
-          name: Install SwiftLint
-          when: always
-          command: |
-            brew install swiftlint
-      - run:
-          name: Danger
-          when: always
-          command: |
-            if [ -n "$DANGER_GITHUB_API_TOKEN" ]; then bundle exec danger; else echo "Skipping Danger for forked pull request."; fi
-      - run:
-          name: Upload to Codecov
-          when: always
-          command: bash <(curl -s https://codecov.io/bash) -f build/BonMot-iOS/slather/cobertura.xml -X coveragepy -X gcov -X xcode
-
   swift-package:
     executor: xcode-14
     steps:
@@ -139,10 +86,6 @@ workflows:
   version: 2
   build-test-deploy:
     jobs:
-      - danger:
-          filters:
-            tags:
-              only: /.*/
       - swift-package:
           filters:
             tags:
@@ -162,7 +105,6 @@ workflows:
       - deploy-to-cocoapods:
           context: CocoaPods
           requires:
-            - danger
             - swift-package
             - fastlane-tests
             - fastlane-tests-xcode-15

diff --git a/Dangerfile b/Dangerfile
diff --git a/Gemfile b/Gemfile
@@ -1,22 +1,8 @@
 source 'https://rubygems.org'
 
 gem 'cocoapods'
+gem 'fastlane'
 gem 'xcpretty'
 
-# Danger
-group :test, :danger do
-  gem 'slather'
-  gem 'circleci_artifact'
-  gem 'xcov'
-  gem 'fastlane'
-end
-
-group :danger do
-  gem 'danger'
-  gem 'danger-swiftlint'
-  gem 'danger-xcov'
-  gem 'danger-junit'
-end
-
 plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
 eval_gemfile(plugins_path) if File.exist?(plugins_path)
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -39,15 +39,7 @@ GEM
     babosa (1.0.4)
     base64 (0.2.0)
     bigdecimal (3.1.5)
-    circleci (2.1.0)
-    circleci_artifact (0.1.0)
-      circleci (~> 2.0)
     claide (1.1.0)
-    claide-plugins (0.9.2)
-      cork
-      nap
-      open4 (~> 1.3)
-    clamp (1.3.2)
     cocoapods (1.14.3)
       addressable (~> 2.8)
       claide (>= 1.0.2, < 2.0)
@@ -91,31 +83,6 @@ GEM
       highline (~> 2.0.0)
     concurrent-ruby (1.2.2)
     connection_pool (2.4.1)
-    cork (0.3.0)
-      colored2 (~> 3.1)
-    danger (9.4.2)
-      claide (~> 1.0)
-      claide-plugins (>= 0.9.2)
-      colored2 (~> 3.1)
-      cork (~> 0.1)
-      faraday (>= 0.9.0, < 3.0)
-      faraday-http-cache (~> 2.0)
-      git (~> 1.13)
-      kramdown (~> 2.3)
-      kramdown-parser-gfm (~> 1.0)
-      no_proxy_fix
-      octokit (>= 4.0)
-      terminal-table (>= 1, < 4)
-    danger-junit (1.0.2)
-      danger (> 2.0)
-      ox (~> 2.0)
-    danger-swiftlint (0.34.0)
-      danger
-      rake (> 10)
-      thor (~> 0.19)
-    danger-xcov (0.5.0)
-      danger (>= 2.1)
-      xcov (>= 1.7.3)
     declarative (0.0.20)
     digest-crc (0.6.5)
       rake (>= 12.0.0, < 14.0.0)
@@ -146,8 +113,6 @@ GEM
     faraday-em_http (1.0.0)
     faraday-em_synchrony (1.0.0)
     faraday-excon (1.1.0)
-    faraday-http-cache (2.5.0)
-      faraday (>= 0.8)
     faraday-httpclient (1.0.1)
     faraday-multipart (1.0.4)
       multipart-post (~> 2)
@@ -203,9 +168,6 @@ GEM
     fourflusher (2.3.1)
     fuzzy_match (2.0.4)
     gh_inspector (1.1.3)
-    git (1.18.0)
-      addressable (~> 2.8)
-      rchardet (~> 1.8)
     google-apis-androidpublisher_v3 (0.54.0)
       google-apis-core (>= 0.11.0, < 2.a)
     google-apis-core (0.11.2)
@@ -253,13 +215,8 @@ GEM
     jmespath (1.6.2)
     json (2.7.1)
     jwt (2.7.1)
-    kramdown (2.4.0)
-      rexml
-    kramdown-parser-gfm (1.1.0)
-      kramdown (~> 2.0)
     mini_magick (4.12.0)
     mini_mime (1.1.5)
-    mini_portile2 (2.8.5)
     minitest (5.20.0)
     molinillo (0.8.0)
     multi_json (1.15.0)
@@ -269,22 +226,11 @@ GEM
     nap (1.1.0)
     naturally (2.2.1)
     netrc (0.11.0)
-    no_proxy_fix (0.1.2)
-    nokogiri (1.15.5)
-      mini_portile2 (~> 2.8.2)
-      racc (~> 1.4)
-    octokit (8.0.0)
-      faraday (>= 1, < 3)
-      sawyer (~> 0.9)
-    open4 (1.3.4)
     optparse (0.1.1)
     os (1.1.4)
-    ox (2.14.17)
     plist (3.7.0)
     public_suffix (4.0.7)
-    racc (1.7.3)
     rake (13.1.0)
-    rchardet (1.8.0)
     representable (3.2.0)
       declarative (< 0.1.0)
       trailblazer-option (>= 0.1.1, < 0.2.0)
@@ -295,9 +241,6 @@ GEM
     ruby-macho (2.5.1)
     ruby2_keywords (0.0.5)
     rubyzip (2.3.2)
-    sawyer (0.9.2)
-      addressable (>= 2.3.5)
-      faraday (>= 0.17.3, < 3)
     security (0.1.3)
     signet (0.18.0)
       addressable (~> 2.8)
@@ -307,17 +250,9 @@ GEM
     simctl (1.6.10)
       CFPropertyList
       naturally
-    slack-notifier (2.4.0)
-    slather (2.8.0)
-      CFPropertyList (>= 2.2, < 4)
-      activesupport
-      clamp (~> 1.3)
-      nokogiri (>= 1.14.3)
-      xcodeproj (~> 1.21)
     terminal-notifier (2.0.0)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
-    thor (0.20.3)
     trailblazer-option (0.1.2)
     tty-cursor (0.7.1)
     tty-screen (0.8.2)
@@ -338,32 +273,17 @@ GEM
       colored2 (~> 3.1)
       nanaimo (~> 0.3.0)
       rexml (~> 3.2.4)
-    xcov (1.8.1)
-      fastlane (>= 2.141.0, < 3.0.0)
-      multipart-post
-      slack-notifier
-      terminal-table
-      xcodeproj
-      xcresult (~> 0.2.0)
     xcpretty (0.3.0)
       rouge (~> 2.0.7)
     xcpretty-travis-formatter (1.0.1)
       xcpretty (~> 0.2, >= 0.0.7)
-    xcresult (0.2.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  circleci_artifact
   cocoapods
-  danger
-  danger-junit
-  danger-swiftlint
-  danger-xcov
   fastlane
-  slather
-  xcov
   xcpretty
 
 BUNDLED WITH