add microsoft UT #83
add microsoft UT #83
Conversation
| var dataSourceItem = new MicrosoftAzureAnalysisServicesDataSourceItem(title, dataSource); | ||
|
|
||
| // Assert | ||
| Assert.Equal(title, dataSourceItem.Title); |
There was a problem hiding this comment.
I think we can use Theory to increase the coverage of unit tests. For ex the commit: https://github.com/RevealBi/Reveal.Sdk.Dom/pull/93/commits/051374207ac976bf40077db08ac82c5c5948b088
The base constructor should also check:
- Assert.Equal(dataSource.Id, dataSourceItem.DataSourceId);
- Assert.Equal(expectedDSTitle, dataSourceItem.DataSource.Item);
| var dataSourceItem = new MicrosoftAzureSqlServerDataSourceItem(title, dataSource); | ||
|
|
||
| // Assert | ||
| Assert.Equal(title, dataSourceItem.Title); |
There was a problem hiding this comment.
I think we can use Theory to increase the coverage of unit tests. For ex the commit: https://github.com/RevealBi/Reveal.Sdk.Dom/pull/93/commits/051374207ac976bf40077db08ac82c5c5948b088
The base constructor should also check:
- Assert.Equal(dataSource.Id, dataSourceItem.DataSourceId);
- Assert.Equal(expectedDSTitle, dataSourceItem.DataSource.Item);
| var dataSourceItem = new MicrosoftAzureSynapseAnalyticsDataSourceItem(title, dataSource); | ||
|
|
||
| // Assert | ||
| Assert.Equal(title, dataSourceItem.Title); |
There was a problem hiding this comment.
I think we can use Theory to increase the coverage of unit tests. For ex the commit: https://github.com/RevealBi/Reveal.Sdk.Dom/pull/93/commits/051374207ac976bf40077db08ac82c5c5948b088
The base constructor should also check:
- Assert.Equal(dataSource.Id, dataSourceItem.DataSourceId);
- Assert.Equal(expectedDSTitle, dataSourceItem.DataSource.Item);
| var dataSourceItem = new MicrosoftOneDriveDataSourceItem(title, dataSource); | ||
|
|
||
| // Assert | ||
| Assert.Equal(title, dataSourceItem.Title); |
There was a problem hiding this comment.
I think we can use Theory to increase the coverage of unit tests. For ex the commit: https://github.com/RevealBi/Reveal.Sdk.Dom/pull/93/commits/051374207ac976bf40077db08ac82c5c5948b088
The base constructor should also check:
- Assert.Equal(dataSource.Id, dataSourceItem.DataSourceId);
- Assert.Equal(expectedDSTitle, dataSourceItem.DataSource.Item);
| var dataSourceItem = new MicrosoftSharePointDataSourceItem(title, dataSource); | ||
|
|
||
| // Assert | ||
| Assert.Equal(title, dataSourceItem.Title); |
There was a problem hiding this comment.
I think we can use Theory to increase the coverage of unit tests. For ex the commit: https://github.com/RevealBi/Reveal.Sdk.Dom/pull/93/commits/051374207ac976bf40077db08ac82c5c5948b088
The base constructor should also check:
- Assert.Equal(dataSource.Id, dataSourceItem.DataSourceId);
- Assert.Equal(expectedDSTitle, dataSourceItem.DataSource.Item);
| { | ||
| // Arrange | ||
| var dataSource = new MicrosoftAnalysisServicesDataSource(); | ||
| var port = 8123; |
There was a problem hiding this comment.
should Port be string for consitency in HostDataSource?
No description provided.