Answer #10
Open
Answer #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A RESTFUL API Calculator with Node.js. |
sscovil
reviewed
Nov 9, 2018
|
|
||
| ### Goal: Build a Simple Calculator using JS OOP best practices | ||
| This is a OOP concept calculator with a RESTFUL API to separate logic from front-end development. |
There was a problem hiding this comment.
When writing an application, it is important to use the right tool for the job. In this case, a REST API is not the right tool. Calculations can be done right in the browser, no need to make a trip to the server to get the answer.
sscovil
reviewed
Nov 9, 2018
| <input readonly class="answer" value="0"/> | ||
| <section class="row"> | ||
| <button name="number" value="1">1</button> | ||
| <button name="number" value="2">2</button> |
There was a problem hiding this comment.
The name attribute should be unique, like an ID (it is used when submitting form data). You would be better off assigning a class here, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completed the challenge: 5
I feel good about my code: 4
I would like comments that could make my code dryer. Also coding edges cases that would cause my calculator application to break.