Skip to content

Commit

Permalink
[dotnet] Add reflection-based JSON serialization fallback to Commands
Browse files Browse the repository at this point in the history
  • Loading branch information
RenderMichael committed Nov 8, 2024
1 parent f8d6c36 commit 702f846
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dotnet/src/webdriver/Command.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
using System.Collections.Generic;
using System.Text.Json;
using System.Text.Json.Serialization;
using System.Text.Json.Serialization.Metadata;

namespace OpenQA.Selenium
{
Expand All @@ -35,7 +36,7 @@ public class Command

private readonly static JsonSerializerOptions s_jsonSerializerOptions = new()
{
TypeInfoResolver = CommandJsonSerializerContext.Default,
TypeInfoResolver = JsonTypeInfoResolver.Combine(CommandJsonSerializerContext.Default, new DefaultJsonTypeInfoResolver()),
Converters = { new ResponseValueJsonConverter() }
};

Expand Down
22 changes: 22 additions & 0 deletions dotnet/test/common/CommandTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
using NUnit.Framework;
using System.Collections.Generic;

namespace OpenQA.Selenium
{
[TestFixture]
public class CommandTests
{
[Test]
public void CommandSerializesAnonymousType()
{
var parameters = new Dictionary<string, object>
{
["arg"] = new { param1 = true, param2 = false },
};

var command = new Command(new SessionId("session"), "test command", parameters);

Assert.That(command.ParametersAsJsonString, Is.EqualTo("""{"arg":{"param1":true,"param2":false}}"""));
}
}
}

0 comments on commit 702f846

Please sign in to comment.