Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net461 and net462 targets #10

Closed
wants to merge 1 commit into from
Closed

Conversation

Foxtrek64
Copy link
Contributor

@Foxtrek64 Foxtrek64 commented Apr 7, 2023

Fixes #9

Blocked by Remora/Remora.Sdk#3 (build will not succeed until this issue is fixed)

@Nihlus
Copy link
Member

Nihlus commented May 1, 2023

Is net462 required? The library already builds for netstandard2.0, which claims support for .NET 4.6.2.

@Nihlus
Copy link
Member

Nihlus commented May 1, 2023

Also, TupleElementNamesAttribute is still missing with PolySharp installed. I've switched to it in Remora.Sdk anyway because it's more feature-complete, but it seems like this is one piece that's still missing.

@Nihlus
Copy link
Member

Nihlus commented May 1, 2023

Follow-up issue: installing System.ValueTuple conditionally fixes that issue, but now I'm getting multiple definitions of IsExternalInit instead.

Related: Sergio0694/PolySharp#48

@Foxtrek64
Copy link
Contributor Author

Foxtrek64 commented May 1, 2023

Is net462 required? The library already builds for netstandard2.0, which claims support for .NET 4.6.2.

I was looking into this again - Microsoft attempted to retroactively add support for net461 to netstandard2.0, which completely broke and they never actually went and fixed it. Net462 was not affected and will receive support through netstandard2.0.

TL;DR: No, it is not required. Net461 is required because of bugs with the interface between Net461 and Netstandard2.0.

@Nihlus
Copy link
Member

Nihlus commented May 1, 2023

I've pushed some experimental changes that don't require PolySharp and it seems to work okay on my end. Can you test and make sure?

@Foxtrek64
Copy link
Contributor Author

I created a test project in UiPath C# (the more finnicky of the two on this version) with effectively this code:

Result<string> result = "Success!";
MessageBox.Show(result.Entity);

And the message box appeared as expected.

@Nihlus
Copy link
Member

Nihlus commented May 2, 2023

I'll close this, then.

@Nihlus Nihlus closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add net461 target
2 participants