-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add formatDate function to calcFunctions #2162
base: beta
Are you sure you want to change the base?
Add formatDate function to calcFunctions #2162
Conversation
…and-text-widgets # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@AntoineRelief |
@TaiKamilla |
1d3b44a
to
fefb391
Compare
…&-summary-card-)-to-format-dates # Conflicts: # libs/shared/src/lib/utils/parser/utils.ts
…&-summary-card-)-to-format-dates # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TaiKamilla, strange issue but it seems not all locale are available, if I put my own local or use the default one(Intl.DateTimeFormat().resolvedOptions().locale) doesn't work in my case(pt-BR), perhaps we could define a default that works when we got error in creating the calc function.
This is due to the fact that not all locales are imported by default, and it might not be a great idea to import them all, because size Adding this will make Spanish and Portuguese (and the others like pt-BR) work
Maybe we get a selection? or we can leave it like this Maybe some feedback on this, @AntoineRelief? |
Description
Added calc.formatDate method to the text editor
I took the liberty of making some of the parameters optional
Useful links
Type of change
Please delete options that are not relevant.
Screenshots
Checklist:
( * == Mandatory )