Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context #2141

Open
wants to merge 7 commits into
base: feat/AB#80876-add-geographic-context-in-page
Choose a base branch
from

Conversation

RenzoPrats
Copy link
Contributor

@RenzoPrats RenzoPrats commented Dec 7, 2023

Description

Feat: Added logic to create/edit and load page with a specific geographic context.

Useful links

ticket
backend

Type of change

  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

It has been tested setting up a geographic context and verifying if it's created a dashboard when we don't have one for this context and if it's loaded when we have one for this context, also tested with resource/referenceData context at the same time that geographic is enabled.

Screenshots

Peek 11-12-2023 16-21

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RenzoPrats RenzoPrats changed the base branch from alpha to feat/AB#80876-add-geographic-context-in-page December 7, 2023 20:22
@RenzoPrats RenzoPrats changed the title Feat/ab#80877 add logic to create edit load page with geographic context feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context Dec 7, 2023
@RenzoPrats RenzoPrats requested a review from a team December 11, 2023 19:26
@RenzoPrats RenzoPrats self-assigned this Dec 11, 2023
@RenzoPrats RenzoPrats added the enhancement New feature or request label Dec 11, 2023
@RenzoPrats RenzoPrats marked this pull request as ready for review December 11, 2023 19:26
@RenzoPrats RenzoPrats requested review from a team and removed request for a team December 11, 2023 19:27
….com-relief:ReliefApplications/ems-frontend into feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
…ext feat: add context enable checker on the query params load for dashboard template in order to avoid the context page creation if not enabled by manually setting params in the url browser bar refactor: onContextChange method for both record and geographic context in order to handle it in the same function refactor: create function for context listeners to keep all in the same place in favor of a more readable code refactor: dashboard template load logic in order to have a clearer and more understandable flow read of the logic within refactor: remove unnecessary debounceTime pipe for select menus(search debounceTime is handled in the ui component)
Copy link
Contributor

@unai-reliefapp unai-reliefapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @RenzoPrats 👍
Looks fine to me @AntoineRelief

…ext fix: region and country property switch and save in order to exclude each other
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants