-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context #2141
Open
RenzoPrats
wants to merge
7
commits into
feat/AB#80876-add-geographic-context-in-page
Choose a base branch
from
feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
base: feat/AB#80876-add-geographic-context-in-page
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenzoPrats
changed the base branch from
alpha
to
feat/AB#80876-add-geographic-context-in-page
December 7, 2023 20:22
RenzoPrats
changed the title
Feat/ab#80877 add logic to create edit load page with geographic context
feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
Dec 7, 2023
15 tasks
….com-relief:ReliefApplications/ems-frontend into feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
…ext feat: add context enable checker on the query params load for dashboard template in order to avoid the context page creation if not enabled by manually setting params in the url browser bar refactor: onContextChange method for both record and geographic context in order to handle it in the same function refactor: create function for context listeners to keep all in the same place in favor of a more readable code refactor: dashboard template load logic in order to have a clearer and more understandable flow read of the logic within refactor: remove unnecessary debounceTime pipe for select menus(search debounceTime is handled in the ui component)
unai-reliefapp
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @RenzoPrats 👍
Looks fine to me @AntoineRelief
…ext fix: region and country property switch and save in order to exclude each other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feat: Added logic to create/edit and load page with a specific geographic context.
Useful links
ticket
backend
Type of change
How Has This Been Tested?
It has been tested setting up a geographic context and verifying if it's created a dashboard when we don't have one for this context and if it's loaded when we have one for this context, also tested with resource/referenceData context at the same time that geographic is enabled.
Screenshots
Checklist:
( * == Mandatory )