forked from OndrejVane/AntiPatternDetectionApp
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post BP Stepanek merge #45
Open
ppicha
wants to merge
139
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added links to anti-pattern detail in result table header - added some basic comments in edited files - html code rafactor
- added links to catalogue in AP detail - added constant with base catalogue URL - in each AP added string with file name to catalogue - getter in AntiPattern class will concate base catalogue URL with catalogue file name - catalogue file name should be declare in definition of AP
- removed AP id from form - AP name moved to the header - url to AP catalogue moved to the header
- removed header from popup window
- added form to the AP detail page for editing treshold values - added method to the controller for saving new values
- added top margin to the message container
- added functionality that checks if the thresholds have changed - if the thresholds have changed, the user is informed - added button for recalculation values
- added top margin to warning message
- error message and success message move from bottom to the top of the configuration page
- minor UI changes
- change success message
- sql scripts refactor for string parametrization - added method for inserting substrings into sql queries - substrings extracted to the AP classes - allow reparametrization on configuration page
- added parametrization into query business as usual - minor refactor
- added new data types for checking input parameters - chenged UI for showing error messages - refactor validation of input parameters
- change percentage data type from integer to float - allow decimal values in percentage
- all queries in the files are split into separate queries - each AP has a list of all the queries it needs to evaluate - all queries from the file are loaded at application startup - mineor changes in PositiveNUmber formating - minor fix
- added information icon on cofniguration page next to all substrings configuration values - added popover on information icon for info message
- added rigorously comments - generated java doc for all project
…tus codes such as 403, 404, 500 and general error template
…ion of bootstrap. -- Upgrade in whole project needs to be done.
…ion of bootstrap. -- Upgrade in whole project needs to be done.
… whole application so it's compatible to newer version of bootstrap. Fixed "Select All" label.
…indeterminate, when not all checkboxes are selected. Removed checkbox Select All from footer and added it to header.
…> Auth. mechanism will be changed during time.
…d bold effect and added italic one. Also size of font was changed to lower.
# Conflicts: # src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/controller/AppController.java
# Conflicts: # pom.xml
# Conflicts: # src/main/webapp/WEB-INF/templates/fragments/navbar.html # src/main/webapp/resources/css/style.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.