Update dependencies and refactor the FFI calls #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddm
commented
Nov 22, 2023
There was a problem hiding this comment.
Few small comments. My main concern is that there is a lot of changes and its hard to spot what we might have missed. This is why I believe this should be part of the next major version. And if we do that, maybe we should already mark the internal functions as pub(crate) so they will not be used from outside wrongly?
Also extracts the only public enum which is used: Status. Hiding the "raw" module helps to hide the implementation detail and avoid often API compatibility issues when a change is needed.
MeirShpilraien
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the way the API calls are done, as well as the resulting type conversion is now hidden, which greatly reduces the number of places for the change in the future.
The main change in this PR, besides updating the dependencies, is moving from one way of calling to another, as:
Due to the changed API in the dependencies we use, we had to change the way we call the functions everywhere. By encapsulating the logic inside of a macro like
redis_call, the next time we need to do something like this, we only do it in the macro, instead of the whole project.