add support for Command filter #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshadmi
reviewed
Jul 19, 2021
Co-authored-by: Omer Shadmi <[email protected]>
…ule-rs into command_filter
gavrie
suggested changes
Jul 20, 2021
| unsafe { raw::RedisModule_CommandFilterArgsCount.unwrap()(self.ctx) as usize } | ||
| } | ||
|
|
||
| pub fn args_get(&self, pos: usize) -> Option<RedisString> { |
There was a problem hiding this comment.
The naming is inconsistent with the Redis APIs: "args" vs "arg". Although the APIs are themselves a bit inconsistently named, let's at least not add even more to the confusion and use the same names here.
In any case, it's probably best to wrap this low-level API wrapper with a higher level idiomatic Rust API (e.g. providing an iterator over the args), but that's not urgent.
| status | ||
| } | ||
|
|
||
| pub fn args_replace(&self, pos: usize, arg: RedisString) -> Status { |
There was a problem hiding this comment.
The insert and replace functions are mostly identical; it may make sense to unify the common code (freeing the strings etc.)
| @@ -82,6 +82,31 @@ macro_rules! redis_event_handler { | |||
| }}; | |||
| } | |||
|
|
|||
| #[cfg(feature = "experimental-api")] | |||
| #[macro_export] | |||
| macro_rules! redis_commnad_filter { | |||
There was a problem hiding this comment.
Typo:
Suggested change
| macro_rules! redis_commnad_filter { | |
| macro_rules! redis_command_filter { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.