Versioning script

[chayim]

As per our discussion on #22 this is the first part of versioning, as discussed.

[rafie]

@chayim Can we please please please do bash instead of sh? It really hearts me in my good eye. :-)

[chayim]

Given that it's written in sh and not bash, I'd say don't change it. sh is available across the unixes we support (currently), including *sd, meaning we don't need to install anything special. If we add something bash specific, we can change the #!shebang - but currently it would be inaccurate.

[rafie]

@chayim I'm aware of the advantages of using sh, but I deliberately decided to use bash across the board because sh syntax is very poor. When considering the tradeoff (of having to explicitly install bash on alpine and to cope with bash 3.0 on older macOS versions), I clearly prefer the possibility to use a reasonable syntax and of course bashdb, which is a major improvement in productivity.

[chayim]

Helping with tooling, I totally get. I'm biased to lowest common denominator - so I'll continue writing SH compliant Bash whenever possible. #! change inbound.

Let me know what you think of the function wrapper - and being forced to call the script with any argument (and ignoring it). The reason was to make the script itself sourceable - though we should yank that into shibumi. Personally - I need to call it as a script via make.

[rafie]

@chayim Good news is that we probably can use bashdb to debug sh scripts. However, if we want to go on using shibumi goodies with sh then we're out of luck.
The bigger problems I find with going with sh are:

• A mixed bash/sh environment is looking for trouble,
• Writing proper sh requires more diligence that most people in this group lack. I don't want people to make stupid errors and we chasing them around.
  So let's think about it a bit and see if it is worth it. Up until now, I haven't encounter any real/practical problem of doing bash even with the 3.2 language level (I avoid 5.0 syntax altogether).

[chayim]

Totally. It's a style thing - I try to write most common denominator until I have no choice.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information