fix: changed conditions for date range in header subtitle for ct event #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deodorhunter
requested changes
Dec 3, 2024
src/components/ItaliaTheme/View/Commons/PageHeader/PageHeaderEventDates.jsx
Show resolved
Hide resolved
deodorhunter
approved these changes
Dec 5, 2024
pnicolli
added a commit
that referenced
this pull request
Dec 20, 2024
#825) * fix: changed conditions for date range in header subtitle for ct event * fix: managed terminates after x occurrences --------- Co-authored-by: Piero Nicolli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed render logic for range date or start date in event subtitle
show range --> when there is recurrence or when start date !== end date and when event does not have open end
show start date --> when there is no recurrence and when start date === end date and when event does not have open end
show start to no conclusion --> when it has open end