fix: updated volto_gdp_privacy #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deodorhunter
approved these changes
Nov 21, 2024
deodorhunter
deleted the
bug_58557_only_technical_cookies_breaks_page
branch
pnicolli
pushed a commit
that referenced
this pull request
Nov 22, 2024
|
@deodorhunter @sabrina-bongiovanni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying settings for "Only technical cookies" in gdpr control panel, the page would break everytime the cookie banner is opened.
The code would break as there was no conditional chaining in the profiling cookies section of the code.
The new version of volto-gdpr-privacy has fixed that and does not cause any other issues in the control panel