feat: show end of recurrence date instead of end date in event ct when set #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuliaghisini
requested changes
Oct 23, 2024
giuliaghisini
requested changes
Oct 24, 2024
src/components/ItaliaTheme/View/Commons/PageHeader/PageHeaderEventDates.jsx
Outdated
Show resolved
Hide resolved
….com/RedTurtle/design-comuni-plone-theme into us_59255_event_view_recurrence_dates
giuliaghisini
approved these changes
Oct 24, 2024
pnicolli
pushed a commit
that referenced
this pull request
Nov 7, 2024
…n set (#789) * feat: show end of recurrence date instead of end date in event ct when set * fix: used helper to calculate actual end date * fix: used helper to calculate actual end date + changed render conditions for page header * fix: created helper function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redturtle.tpondemand.com/entity/59486-ricorrenzesplit
Since implementing the new recurrence widget, the start date and the end date of a recurrent event are the same.
In the Event view, this case is managed by showing only the date of the event without taking into account the fact that events occurs multiple times over time.
This PR aims to show the end date of the recurrence when set both in the event subtitle and in the timeline calendar in the dates and time section
from: Reggio Emilia