Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added arrow icon to links in footerNavigation #642

Open
wants to merge 4 commits into
base: v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
- Sistemato il flag Mostra tipologia bandi nel blocco elenco con variazione Bandi in Evidenza
- Tradotto il messaggio per Screen Reader del bottone per aprire e chiudere il menu in mobile.
- Menu dropdown si chiude correttamente quando il percorso è un sottosito con un menu diverso rispetto al sito principale
- Migliorata l'accessibilità dei link nel footer.

## Versione 7.25.3 (07/03/2024)

Expand Down
2 changes: 2 additions & 0 deletions src/components/ItaliaTheme/Footer/FooterNavigation.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
LinkListItem,
} from 'design-react-kit/dist/design-react-kit';
import { SectionIcon } from 'design-comuni-plone-theme/components/ItaliaTheme';
import { Icon } from 'design-comuni-plone-theme/components/ItaliaTheme';
import config from '@plone/volto/registry';

const messages = defineMessages({
Expand Down Expand Up @@ -73,6 +74,7 @@ const FooterNavigation = () => {
}
>
{item.title}
<Icon icon="it-arrow-right" color="white" />
</Link>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</Link>
<Link
to={item.url}
title={
intl.formatMessage(messages.goToPage) + ': ' + item.title
}
>
<SectionIcon
section={item.url}
iconProps={{ size: 'sm', color: 'white', className: 'mr-2' }}
/>
{item.title}
<Icon icon="it-arrow-right" color="white" size="sm" />
</Link>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tranne questo, forse dare una classe al link per il display flex

</h4>
{!config.settings.isFooterCollapsed && item.items && (
Expand Down
Loading