fix: Report any unknown options found on the command line.

[jvlcek]

Card ID: CCT-524

The rhc subcommands, connect, disconnect and status ignore any unknown options given. This PR will fix this by returning an error when any unknown options are found.

The following tests were performed:

Test 1: One unknown argument give.

% sudo  ./rhc connect activation-key 
error: unknown option(s): activation-key 

Test 2: Valid arguments given but unknown arguments were also given. The extra unknown
arguments will produce an error.

% sudo  ./rhc connect --activation-key ${MY_KEY} --organization ${MY_ORG}  bobs your uncle
error: unknown option(s): bobs your uncle 

[Lorquas]

Can one of the admins verify this patch?

[jirihnidek]

/packit build

[jirihnidek]

Thanks for the PR. I have few requests and suggestions.

[jvlcek]

Thank you for the review input @jirihnidek! It's very much appreciated. I actually reflected on this after I submitted it and realized I should dry up the code. Your suggestions are spot on.

I believe I have addressed them in commit: af612bd

and retested the following:

lima% sudo  ./rhc connect activation-key
error: unknown option(s): activation-key

lima% sudo  ./rhc connect --activation-key ${MY_KEY} --organization ${MY_ORG}  bobs your uncle
error: unknown option(s): bobs your uncle

lima% sudo ./rhc status --format foo bar
unsupported format: foo (supported formats: "json")

lima% sudo ./rhc status bobs your uncle
error: unknown option(s): bobs your uncle

[jvlcek]

@jirihnidek I believe I've addressed all of the changes you have requested. Please let me know what you think now.

[jirihnidek]

LGTM, thanks for updates 👍

[jirihnidek]

/packit build

[jvlcek]

Thank you for the help with this @jirihnidek