Arduino Stream fix #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renaming of
StreamtoWStreambroke compatibility with Arduino libraries and sketches. This PR will fix the Stream issue for Arduino, but will break mbed support. However, Arduino users and library developers should not need to change every instance ofStreamtoWStreamjust to be compatible with RedBear boards.Honestly, I don't think my PR is acceptable since it will break mbed user's applications but I want to get it out there since IMHO this is a serious issue. The real problem is that integration of an mbed core into an Arduino core just does not work and should be avoided. Please consider separating Arduino and mbed functionality into separate repositories, perhaps sharing common code via submodules if absolutely necessary.
I don't know what it takes to untangle the mbed code from the Arduino code in this repo (nor do I have any mbed boards to test with) or I'd take a pass at a proper solution of splitting repositories myself.
In the mean time, the
stream-fixbranch in my fork will at least provide a usable solution for Arduino users. I'll try to keep it up to date.