Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

feat(stackblitz): stackblitz implementation poc #252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sumitarora
Copy link
Collaborator

Did initial POC of stackblitz implementation implemented on two operators http://localhost:4200/#/operators/concat and http://localhost:4200/#/operators/combineAll

image

image

@ashwin-sureshkumar @ladyleet @btroncone 😄

@ladyleet
Copy link
Member

ladyleet commented Feb 6, 2018

oh baby!

@rxjs-bot
Copy link

rxjs-bot commented Feb 6, 2018

Warnings
⚠️

❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Feb 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@91a3918). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #252   +/-   ##
=========================================
  Coverage          ?   77.14%           
=========================================
  Files             ?       15           
  Lines             ?      175           
  Branches          ?        7           
=========================================
  Hits              ?      135           
  Misses            ?       40           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a3918...57caa86. Read the comment docs.

@DiedrikDM
Copy link
Contributor

Apparently no console? Do we need it for our documentation? I like your solution where we add it in the HTML, but our docs will need to change ofc...

@sumitarora
Copy link
Collaborator Author

@DiedrikDM yes for sure this is just a POC to see it would work in our case.

@btroncone
Copy link
Collaborator

Look awesome, very exciting!

Check out the styling I had for the stackblitz embeds in the Angular / React examples branch. This will normalize the top and bottom colors for the example panes to match stackblitz colors. :)

@niklas-wortmann
Copy link
Member

Looks pretty awesome. Great job!

@EricSimons
Copy link

@DiedrikDM @sumitarora would y'all want an integrated console? Bc we're actually going to be rolling that out in mid-late March :)

@btroncone
Copy link
Collaborator

@EricSimons That would be awesome! I also started converting my learnrxjs examples to stackblitz and that's the one thing I missed. Can't wait for this!

@sumitarora
Copy link
Collaborator Author

@EricSimons That would be awesome as I am currently modifying all examples to display output in HTML as all our examples used console.log. I can leave them as it is yay!! :D

@ladyleet
Copy link
Member

@EricSimons kicking some butt! :) we are so excited.

@EricSimons
Copy link

EricSimons commented Mar 7, 2018

Hey all! Just wanted to let everyone know we're still on track for mid-late March release of the integrated console. We're actually porting chrome devtools to work inside of stackblitz for this, so it should end up being a very awesome & familiar debugging experience (which is also why it's taking a few weeks instead of a few days :)

@EricSimons
Copy link

@btroncone @sumitarora @ladyleet it's live! Take a peek:
screen shot 2018-03-29 at 6 22 18 pm

We have a query param for setting the console height from 0-100% (see it in action here), will also be adding it to the SDK tomorrow and marking a new release 🍻

Would love to hear your thoughts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants