-
Notifications
You must be signed in to change notification settings - Fork 62
feat(stackblitz): stackblitz implementation poc #252
base: master
Are you sure you want to change the base?
Conversation
oh baby! |
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=========================================
Coverage ? 77.14%
=========================================
Files ? 15
Lines ? 175
Branches ? 7
=========================================
Hits ? 135
Misses ? 40
Partials ? 0 Continue to review full report at Codecov.
|
Apparently no console? Do we need it for our documentation? I like your solution where we add it in the HTML, but our docs will need to change ofc... |
@DiedrikDM yes for sure this is just a POC to see it would work in our case. |
Look awesome, very exciting! Check out the styling I had for the stackblitz embeds in the Angular / React examples branch. This will normalize the top and bottom colors for the example panes to match stackblitz colors. :) |
Looks pretty awesome. Great job! |
@DiedrikDM @sumitarora would y'all want an integrated console? Bc we're actually going to be rolling that out in mid-late March :) |
@EricSimons That would be awesome! I also started converting my learnrxjs examples to stackblitz and that's the one thing I missed. Can't wait for this! |
@EricSimons That would be awesome as I am currently modifying all examples to display output in HTML as all our examples used |
@EricSimons kicking some butt! :) we are so excited. |
92b02fb
to
1358093
Compare
Hey all! Just wanted to let everyone know we're still on track for mid-late March release of the integrated console. We're actually porting chrome devtools to work inside of stackblitz for this, so it should end up being a very awesome & familiar debugging experience (which is also why it's taking a few weeks instead of a few days :) |
@btroncone @sumitarora @ladyleet it's live! Take a peek: We have a query param for setting the console height from 0-100% (see it in action here), will also be adding it to the SDK tomorrow and marking a new release 🍻 Would love to hear your thoughts! |
Did initial POC of stackblitz implementation implemented on two operators http://localhost:4200/#/operators/concat and http://localhost:4200/#/operators/combineAll
@ashwin-sureshkumar @ladyleet @btroncone 😄