Fix starmap_indexed not passing index #690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boudewijn26
commented
Feb 16, 2023
| @@ -65,7 +65,7 @@ def _identity(value: _T1, _: int) -> _T2: | |||
|
|
|||
| return compose( | |||
| ops.zip_with_iterable(infinite()), | |||
| ops.starmap_indexed(_mapper_indexed), | |||
| ops.starmap(_mapper_indexed), | |||
There was a problem hiding this comment.
This depended on the incorrect behavior of starmap_indexed. If it actually were to pass the index, it would pass it twice: once from zip_with_iterable(infinite()) and once from starmap_indexed
| @@ -405,6 +405,211 @@ def mapper(x, y): | |||
| assert xs.subscriptions == [subscribe(200, 290)] | |||
| assert invoked[0] == 3 | |||
|
|
|||
| def test_starmap_with_index_throws(self): | |||
There was a problem hiding this comment.
Tests derived from
RxPY/tests/test_observable/test_map.py
Line 265 in 8263b1e
Boudewijn26
force-pushed
the
fix/starmap_indexed
branch
2 times, most recently
from
13100f7
to
cab78b4
Compare
MainRo
force-pushed
the
fix/starmap_indexed
branch
from
cab78b4
to
b6ffaff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
starmap_indexednot actually passing the index to the functionThis could be considered a breaking change, although I suspect the impact would be minor. Anyone currently using
starmap_indexedmust have noticed it's no different fromstarmap