Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Play lanes in time selection v1.03 #1455

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Edgemeal
Copy link
Contributor

@Edgemeal Edgemeal commented Nov 3, 2024

Fix window positioning
Allow user to move window with mouse

Fix window positioning
Allow user to move window with mouse
@@ -213,5 +211,6 @@ r.set_action_options(1|4)
if reaper.HasExtState("Edgemeal", "play_lanes") then no_buf, play_all, skip_comps, only_comps = LoadValues() end -- load usres previous settings (this session only)
-- get mouse pos (app will be centered @ mouse)
x, y = r.GetMousePosition()
x, y = ImGui.PointConvertNative(ctx, x, y, true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_native should be false for a native (from OS) -> normalized (to ImGui) conversion:

Suggested change
x, y = ImGui.PointConvertNative(ctx, x, y, true)
x, y = ImGui.PointConvertNative(ctx, x, y, false)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I edited the code, hope that works!

Hopefully fixed code so script window is centereed at mouse on all OS.
@cfillion cfillion merged commit 9647181 into ReaTeam:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants