Update OneSmallStep v0.9.6 > v0.9.7 #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfillion
reviewed
Mar 12, 2024
| @@ -9,6 +9,11 @@ | |||
| [main=main,midi_editor] talagan_OneSmallStep/actions/talagan_OneSmallStep Change input mode.lua > talagan_OneSmallStep/actions/talagan_OneSmallStep Change input mode - KeyboardPress.lua | |||
There was a problem hiding this comment.
MIDIUtils.lua is not listed in the included files:
[nomain] talagan_OneSmallStep/lib/*.lua
There was a problem hiding this comment.
Yeah, it's in talagan_OneSmallStep/classes/lib and I stupidly thought that
[nomain] talagan_OneSmallStep/classes/*.lua
was recursive. Happily you were vigilant !! Correcting this right away.
There was a problem hiding this comment.
Done. Thanks for your watchfulness !
There was a problem hiding this comment.
Thanks for the tip, I've accepted your suggestion. Bonne nuit ! :)
cfillion
reviewed
Mar 12, 2024
Co-authored-by: Christian Fillion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog :