Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OneSmallStep v0.9.4 > v0.9.5 #1326

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

BenTalagan
Copy link
Contributor

Update for One Small Step, v 0.9.5. Changelog :

  • [Feature] Added insert/cursor mode (inserts + move things forward, deletes backwards)
  • [Feature] Added pedal repeater
  • [UI] Added status icons for modifier modes/keys (insert / backward / insert+backward)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of these sub-actions and it keeps growing, perhaps they could be moved to the talagan_OneSmallStep folder to keep the parent MIDI Editor clean?

Normally (as done when using reapack.com/upload), all secondary files are in a subfolder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, and it's probably going to grow more and more. The original idea was to have all callable actions in the MIDI Editor dir, and lib files in subfolders. But now the tool is getting more sophisticated than expected, so there's probably a need to re-organise things. I'll take the time (and extra care) to do it tomorrow, since there's one or two things to be careful (action IDs are going to change for example, and cross referenced paths too). I'll move every secondary action in an "actions" subfolder of the main subfolder.

@BenTalagan
Copy link
Contributor Author

Ok, this should be good now. !

@cfillion cfillion merged commit 09214ba into ReaTeam:master Feb 29, 2024
1 check passed
@BenTalagan BenTalagan deleted the talagan/one_small_step/v0.9.5 branch March 6, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants