Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Link FX chains of 2 different tracks (GUI) v1.0 #1301

Conversation

mattia-marini
Copy link

No description provided.

@cfillion
Copy link
Member

  1. The 'ReaLink' name might be confused with 'ReaLinks' which already exists in the REAPER community: https://www.realinks.net/
  2. Action names should use sentence case: 'Marini_ReaLink_Ui_Toggle.lua' --> 'Marini_ReaLink UI toggle.lua'
  3. GetActionCommandIDByFilename is not necessary: ReaPack installs actions to a deterministic path so their command ID can be relied on (script command IDs are a SHA1 hash of their path)
  4. Was limiting this package to be macOS-only on purpose? I see that some code checks for Windows with reaper.GetOS().

@mattia-marini
Copy link
Author

First of all thank you for the speedy feedback!

  1. After getting fixed what you listed, should I push to the fork or should I re-upload everything to https://reapack.com/upload/reascript?

  2. I didn't find any api function to generate the SHA1, am I missing something or should I implement a function on my own?

  3. I limited it intentionally since I'm not sure the UI would scale properly and I have no way of testing it on Windows. I will for sure add the support in the near future

@cfillion
Copy link
Member

  1. It's fine either way

  2. Install the script at the same location as ReaPack, then Action List > Copy selected action command ID

    For example, this opens the ReaImGui demo script on all systems:

    reaper.Main_OnCommand(reaper.NamedCommandLookup('_RS6b4644d86854e10895485f184942fb69ecc26177'), 0)
  3. OK!

I've updated reapack.com to show the predicted command ID:
Update

@mattia-marini mattia-marini force-pushed the reapack.com_upload-1706612744937 branch from 3f97e5c to 24a4efc Compare March 9, 2024 17:45
@mattia-marini
Copy link
Author

Sorry for the delay in response, it's been rough weeks... Anyway, I've pushed the recommended changes to the fork, I hope I haven't made any newbie mistakes, that's my first time contributing to open source. Thanks for your patience ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants