Release Mixing Station track name import v1.0 #1293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfillion
reviewed
Jan 16, 2024
| end | ||
|
|
||
| -- Run the script | ||
| reaper.defer(main) |
There was a problem hiding this comment.
Why delay main until up to 30ms later? The entire contents of main could be probably extracted out of it and put directly in the script, no function or defer required.
| -- Function to prompt the user for a file | ||
| function getUserFile() | ||
| local userFile = reaper.GetResourcePath() | ||
| local _, file = reaper.GetUserFileNameForRead(userFile, "Please load an MS Scene (Default: C:\\Users\\[user]\\MixingStaion\\Presets)", "json") |
There was a problem hiding this comment.
Typo? s/MixingStaion/MixingStation/
What's the default path on macOS and Linux? If this script is only meant for Windows, installation should be limited to it using the "Target platform" field.
Shouldn't the MixingStation Presets folder be given to GetUserFileNameForRead instead of REAPER's resource path?
By the way Lua has select for skipping unused leading values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.