Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Track Color Layouts v1.0 #1277

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

BenTalagan
Copy link
Contributor

Pull request for releasing the first version of a new tool, "Track Color Layouts".

The installation generates 4 children script for 4 layouts from the base "virtual" action script.

@BenTalagan
Copy link
Contributor Author

BenTalagan commented Oct 21, 2023

Note : I've patched my own PR to add 4 toolbar icons for color layouts. They are provided directly to the user in the toolbar_icons folder so that the toolbar integration is minimal (click, set, and go).

@BenTalagan
Copy link
Contributor Author

BenTalagan commented Oct 22, 2023

@cfillion, something wrong with this PR ? :-) (just asking because it was not merged like others yesterday).

@BenTalagan
Copy link
Contributor Author

Note : added one commit to this PR to update script metadata.

@cfillion
Copy link
Member

cfillion commented Oct 29, 2023

  • The filenames and package name should use sentence case: "Track Color Layouts" -> "Track color layouts"
  • The action filename suffixed with " action.lua" would be a bit odd since that's shown in the user's Action List
  • The library file should be in the "talagan_Track color layout" directory (also sentence case)

@BenTalagan BenTalagan force-pushed the talagan/track_color_layouts/1.0 branch from dbad96c to 13d02d8 Compare October 29, 2023 08:43
@BenTalagan
Copy link
Contributor Author

BenTalagan commented Oct 29, 2023

  • The filenames and package name should use sentence case: "Track Color Layouts" -> "Track color layouts"

On this point I had a hard time between macos, reapack-index and git due to case sensitvity. I had to git push force my branch to avoid problems, because precedent commits in the PR would trigger warnings with reapack-index.

  • The action filename suffixed with " action.lua" would be a bit odd since that's shown in the user's Action List

Caution, it is not shown in the user's action list due to the rewriting of the action to different versions (layout 1, layout2, etc).

  [main=main,midi_editor] . > talagan_Track color layout 1.lua
  [main=main,midi_editor] . > talagan_Track color layout 2.lua
  [main=main,midi_editor] . > talagan_Track color layout 3.lua
  [main=main,midi_editor] . > talagan_Track color layout 4.lua

When proceeding that way, reapack skips the writing of the main file in the target dir. So the file is not even present in the REAPER script directory, and it's not a problem ; but in the meanwhile, to be cleaner, I've renamed the action file to, simply, "talagan_Track color layouts.lua" and have moved the lib file to the "talagan_Track color layouts" subdirectory. I have however kept the syntax "layout 1", "layout 2" (singular, not plural) for the actions because each one of those actions is linked to one and only one layout individually.

  • The library file should be in the "talagan_Track color layout" directory (also sentence case)

Done (except that I've used the "talagan_Track color layouts" directory).

I hope this is cleaner and good to be merged now, thank you for the pertinent remarks.

@cfillion
Copy link
Member

All good, merging!

it is not shown in the user's action list due to the rewriting of the action to different versions (layout 1, layout2, etc).

Ah yes, renaming removes the implicit inclusion of the original filename.

@cfillion cfillion merged commit 40c415b into ReaTeam:master Oct 29, 2023
1 check passed
@BenTalagan
Copy link
Contributor Author

Thanks, Christian !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants