-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Track Color Layouts v1.0 #1277
Release Track Color Layouts v1.0 #1277
Conversation
Note : I've patched my own PR to add 4 toolbar icons for color layouts. They are provided directly to the user in the toolbar_icons folder so that the toolbar integration is minimal (click, set, and go). |
@cfillion, something wrong with this PR ? :-) (just asking because it was not merged like others yesterday). |
Note : added one commit to this PR to update script metadata. |
|
dbad96c
to
13d02d8
Compare
On this point I had a hard time between macos, reapack-index and git due to case sensitvity. I had to git push force my branch to avoid problems, because precedent commits in the PR would trigger warnings with reapack-index.
Caution, it is not shown in the user's action list due to the rewriting of the action to different versions (layout 1, layout2, etc).
When proceeding that way, reapack skips the writing of the main file in the target dir. So the file is not even present in the REAPER script directory, and it's not a problem ; but in the meanwhile, to be cleaner, I've renamed the action file to, simply, "talagan_Track color layouts.lua" and have moved the lib file to the "talagan_Track color layouts" subdirectory. I have however kept the syntax "layout 1", "layout 2" (singular, not plural) for the actions because each one of those actions is linked to one and only one layout individually.
Done (except that I've used the "talagan_Track color layouts" directory). I hope this is cleaner and good to be merged now, thank you for the pertinent remarks. |
All good, merging!
Ah yes, renaming removes the implicit inclusion of the original filename. |
Thanks, Christian ! |
Pull request for releasing the first version of a new tool, "Track Color Layouts".
The installation generates 4 children script for 4 layouts from the base "virtual" action script.