Variety of Issue Fixes(Size adjustments, Rectangle Filter, gitignore, sfx) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the gitignore file. I copied the text from gitignore.io and then did the terminal work to implement it. If I did anything wrong, please notify me.
This is the sound effect I'll use. I'm not sure how to implement the sound, since it isn't clear what I'll be using to actually take the picture. Is it clicking the filter or a separate button?
This height variable helped the horizontal line filter cover the whole screen.
I added the horizontal line filter and a function that plays a sound. However, playSound() doesn't work yet because the TakePictureButton is isolated, and I'm not sure how the picture should be taken.
This file is the horizontal line filter. I'll be done with the other two filters soon.
This adds the horizontal case to the filters' enumerator and switch.
This helps the circle filter fit inside the filter scroll and the actual image. I'm not sure if this works on iphone 8 or not, but if it doesn't, I can adjust the parameters.
This helps the rectangle filter fit inside the filter scroll and the actual image. I'm not sure if this works on iphone 8 or not, but if it doesn't, I can adjust the parameters.
I added code that can help the app take photos. However, it can be a bit inconsistent, which I think is because of how the code is formatted. However, I can debug that later, since now that the camera is done, I will focus on the Arduino issues.
|
Reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I solved issues #8, #13, #14, #18, #20, and part of #19(rectangle filter)
Before I solve some other issues, I have a question about the app's functionality. Will a picture be taken from tapping the filter or a separate button?
Thanks for waiting. While waiting on the functionality explanation, I can also potentially start some Arduino work.