-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code for Issues 13(Hide/Show Filters) and 14(Black/White Filter Toggle) #17
Conversation
I revisited the addition file and changed it to a for loop that finds the sum of the first 5 positive integers. This code can help with finding sums and averages. This is very basic code, so it can be adjusted later to allow input for how many or which integers are added.
The buttons in lines 61-80 were added to change the filters' colors(black/white) and visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I will merge.
@@ -0,0 +1,9 @@ | |||
public class Main { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? And is it Java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was for the original test pull request I did for training. Feel free to remove that file.
I adjusted the code to create two buttons: one for hiding or showing the filters, and another for changing the filter's color. The original issue 13 asked for a swipe, but not only would a swipe conflict with photo capturing, but it would also be harder to implement in SwiftUI. The buttons change all of the filters at once to the same visibility or color. The only problem with my code is that the changes don't apply to the current filter. I can fix those later, but right now I'm going to focus on the gitignore or camera functionality. Use the most recent versions of each file if possible, but all of the updates work.