Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for Issues 13(Hide/Show Filters) and 14(Black/White Filter Toggle) #17

Merged
merged 23 commits into from
Jan 10, 2023

Conversation

eibarolle
Copy link
Contributor

I adjusted the code to create two buttons: one for hiding or showing the filters, and another for changing the filter's color. The original issue 13 asked for a swipe, but not only would a swipe conflict with photo capturing, but it would also be harder to implement in SwiftUI. The buttons change all of the filters at once to the same visibility or color. The only problem with my code is that the changes don't apply to the current filter. I can fix those later, but right now I'm going to focus on the gitignore or camera functionality. Use the most recent versions of each file if possible, but all of the updates work.

@eibarolle
Copy link
Contributor Author

#13 #14

@truedat101
Copy link
Member

truedat101 commented Jan 8, 2023 via email

@truedat101 truedat101 self-requested a review January 10, 2023 01:57
Copy link
Member

@truedat101 truedat101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I will merge.

@@ -0,0 +1,9 @@
public class Main {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? And is it Java?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was for the original test pull request I did for training. Feel free to remove that file.

@truedat101 truedat101 merged commit 1d7f7e0 into RazortoothRTC:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants