You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so since I added that other release, it's now shoing 1.1.0 as the latest for some reason... I was thinking of doing a small update to the readme, then replacing the tag for 1.2.0 with that... does that sound like the right thing to do?
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RayViljoen @counterbeing: can you tag 1.2.0 https://github.com/RayViljoen/grunt-sitemap/releases? And even 1.1.0 which is 9184f16
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@counterbeing: thanks! Can you add a release for 1.1.0 too? In the future you'll know the drill :P
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a tag not a release :P
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I'll try to make a small PR tomorrow addressing a few small issues I've noticed.
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so since I added that other release, it's now shoing 1.1.0 as the latest for some reason... I was thinking of doing a small update to the readme, then replacing the tag for 1.2.0 with that... does that sound like the right thing to do?
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just delete 1.2.0 release and add it again without pushing anything.
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually already tried that, and it continues to say that 1.1.0 is later. I think it's because of how I tagged the release and then pushed it.
git tag -a 1.1.0 9184f16da610d29b814ed2f15d1de8555c5d64f5 -m "Older version"Then once I pushed those tags:
git push --tags origin masterIt considers the older stuff newer, as of when I tagged it.
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should just have done the tags via GitHub's web interface I guess.
Anyway, it's not a big deal and we can have a 1.2.1 release when I finish that PR, which should be tomorrow.
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW @counterbeing you need to link the email you used in git on GitHub if you want the commits to link to your profile.
7c9fd23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, thanks, i recently changed that. thanks for all the help!