Create OWASP security scan of Docker container #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://github.com/PrivateBin/docker-nginx-fpm-alpine/blob/master/.github/workflows/owasp.yml Fixes the security part of Ravinou#67 Note the results may include some false-positives. You can later ignore these via [creating a `rules.tsv` file](https://github.com/PrivateBin/docker-nginx-fpm-alpine/blob/master/.github/rules.tsv), but I've commented this for now. See https://github.com/zaproxy/action-full-scan
rugk
added a commit
to rugk/borgwarehouse
that referenced
this pull request
Nov 3, 2023
* You can start it as usual, `.env` file is automatically used. * IMHO easier and cleaner to configure. * Also removed the `<host>` as it makes this not-runnable out-of-the-box. I need this for Ravinou#69 and this was the initial idea of making this PR. * The `${:?}` syntax is a bash-like thing to produce a proper error message if the variable is not provided. I checked the setup should basically start (just got a permission error as the UID/GID is wrong).
Don't get the error, the |
rugk
commented
Nov 3, 2023
.env.sample
Outdated
Comment on lines
14
to
15
| UID=1001 | ||
| GID=1001 |
There was a problem hiding this comment.
Suggested change
| UID=1001 | |
| GID=1001 | |
| UID=$USER | |
| GID=$USER |
Could also use $USER here, which would make it runnable more out-of-the-box?
Ravinou
force-pushed
the
main
branch
2 times, most recently
from
a92b9e9 to
2900455
Compare
|
@Ravinou any review or action needed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/PrivateBin/docker-nginx-fpm-alpine/blob/master/.github/workflows/owasp.yml
Fixes the security part of #67
Note the results may include some false-positives. You can later ignore these via creating a
rules.tsvfile, but I've commented this for now.See https://github.com/zaproxy/action-full-scan