Feature/repo refresh option #251
Conversation
|
@Ravinou what do you think about this? :) |
|
Thank you for this contribution, which I am studying. Could you start by squashing your commits please and add the conventional scopes ? Next, I'll have to take the time to study and test this, as you're touching on core functions, notably the repository creation shells and their regexes. I still have my doubts about reintegrating the triggering of a task like this into borgwarehouse. Originally, v1 had a built-in cron. But it was removed because it was causing problems and nobody recommends doing that. This job should be given to another service. I'll study your PR, I promise, but I don't know if I'll approve it yet. Thanks in any case. |
|
I will rebase :) Wouldn't it be easier to squash the commits here on the PR and i format the PR Text according to the conventional scopes? Then the newly created (squashed) commit by GitHub will be as you wish? Or do you want to fast forward merge to preserve original signatures? |
|
You can do only one commit "feat:", I will study it by merging it in a specific branch. Thanks. |
- Added an env var: AUTO_REFRESH to .env.sample (defaults to false) - Added helper script helpers/shells/cronjob.sh to call the borgwarehouse api for refreshing the repo status and used storage - Added function to add this feature when creating new repositories (if enabled) in helpers/shells/createRepo.sh - Added function to enable/disable this option during startup (depends on the configured bool for AUTO_REFRESH) in docker/docker-bw-init.sh. - This basically inserts or removes an additional command per forced-ssh-command that calls the previous created "cronjob.sh" helper script.
mirisbowring
force-pushed
the
feature/repo-refresh-option
branch
from
de6bfc0 to
50a33cb
Compare
|
Hi, |
|
Thanks, it's much clearer. I'm currently working on token API integration. As soon as it's finished, I'll start working on your proposal in the next few weeks. Thank you for your patience. |
|
Hi @Ravinou I saw your latest relase. Before i invest time into solving the conflicts - are there chances that this PR get's merged? |
|
Hi, for the moment don't do the rebase, I'll have a look when I get the time back ;) |
Hi,
coming from #247 (comment)
I implemented an environmental variable that enables / disables (by default) an
AUTO_REFRESHoption.If this option is enabled, each ssh forced commands get appended a script to call the warehouse api to fetch the latest details about the repo.
This approach is better than any cronjob since it get's executed only if a borg activity has happened (not just on a timely basis).
I hope this get pulled since i expect this to be a useful feature for others also.