Update README to reflect switch to standalone #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
sra405
reviewed
Dec 17, 2024
README.md
Outdated
Comment on lines
13
to
18
| ## Private repo setup (.npmrc) | ||
|
|
||
| The app requires a Git token for access to private repos (currently limited to `design-system-react`). | ||
| The app requires a Git token for access to private repos (currently limited to [`design-system-react`](https://github.com/RaspberryPiFoundation/design-system-react). | ||
|
|
||
| - Generated a token here, it'll be prefixed with `ghp_`: https://github.com/settings/tokens | ||
| - Generate a token [here](https://github.com/settings/tokens) - it should be prefixed with `ghp_` | ||
| - Add a line to the bottom of `~/.npmrc` (this is in addition to the one in the repo): `//npm.pkg.github.com/:_authToken=<github_token>` |
There was a problem hiding this comment.
🔧 I don't think this is true anymore. Both design system packages are public I believe:
There was a problem hiding this comment.
Ah yes okay, I might just get rid of this lot then 👍
sra405
reviewed
Dec 17, 2024
sra405
reviewed
Dec 17, 2024
sra405
reviewed
Dec 17, 2024
sra405
reviewed
Dec 17, 2024
README.md
Outdated
| Other variables that pertain to the app, rather than its deployment are set with defaults in the [build-and-deploy workflow](./.github/workflows/build-and-deploy.yml). These are also in `.env.example`. | ||
| Other variables that pertain to the app, rather than its deployment, are set to default values in the [build-and-deploy workflow file](./.github/workflows/build-and-deploy.yml). These are also in `.env.example`. | ||
|
|
||
| The staging bucket is called [`editor-dist-staging`](https://dash.cloudflare.com/44a2049cd9f2b11d21474e06251367df/r2/default/buckets/editor-dist-staging), and the latest deployment of `main` is available at https://staging-editor-static.raspberrypi.org/branches/main/web-component.html. |
There was a problem hiding this comment.
❓ is it worth mentioning the staging js bundle is located at https://staging-editor-static.raspberrypi.org/branches/main/web-component.js?
There was a problem hiding this comment.
Ah okay, yeah, I might rework this bit a little then to make clear the bundle and preview locations 👍
Co-authored-by: Scott Adams <[email protected]>
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
Co-authored-by: Scott Adams <[email protected]>
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1155/merge
GitHub Actions
Inactive
conorriches
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.