Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy 2.0 update #97

Open
enryH opened this issue Jun 20, 2024 · 0 comments
Open

numpy 2.0 update #97

enryH opened this issue Jun 20, 2024 · 0 comments

Comments

@enryH
Copy link
Member

enryH commented Jun 20, 2024

It looks like currently the installation uses numpy 2.* - which leads to errors:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.9/x64/bin/move-dl", line 5, in <module>
    from move.__main__ import main
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/move/__init__.py", line 5, in <module>
    from move import conf, data, models  # noqa:E402
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/move/conf/__init__.py", line 3, in <module>
    from move.conf.schema import MOVEConfig
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/move/conf/schema.py", line 18, in <module>
    from move.models.vae import VAE
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/move/models/__init__.py", line 3, in <module>
    from move.models.vae import VAE
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/move/models/vae.py", line 10, in <module>
    from move.core.typing import FloatArray, IntArray
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/move/core/__init__.py", line 3, in <module>
    from move.core import logging, typing
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/move/core/typing.py", line 13, in <module>
    FloatArray = NDArray[np.float_]
                         ^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/numpy/__init__.py", line 397, in __getattr__
    raise AttributeError(
AttributeError: `np.float_` was removed in the NumPy 2.0 release. Use `np.float64` instead.. Did you mean: 'float[16](https://github.com/RasmussenLab/MOVE/actions/runs/9566168242/job/26370771716?pr=95#step:5:17)'?

@ri-heme Should we switch to np.float64 in the type annotations?

enryH pushed a commit that referenced this issue Jun 20, 2024
- 16.6.24 numpy 2 was released, some types have to be udpated, see #97
enryH pushed a commit that referenced this issue Jun 20, 2024
- 16.6.24 numpy 2 was released, some types have to be udpated, see #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant