[refactoring]: Changed the getUsersPhotos method

RapDog64 · Jul 14, 2023 · 660cb01 · 660cb01
1 parent a4801b2
commit 660cb01
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/rangiffler-gateway/src/main/java/com/rangiffler/service/PhotoService.java b/rangiffler-gateway/src/main/java/com/rangiffler/service/PhotoService.java
@@ -27,15 +27,17 @@ public PhotoJson addPhoto(PhotoJson photoJson) {
     }
 
     public List<PhotoJson> getAllUserPhotos(String username) {
-        List<PhotoJson> usersPhoto = new ArrayList<>();
         List<PhotoServiceJson> photos = photoService.getPhotosForUser(username);
-        if (!photos.isEmpty()) {
-            for (PhotoServiceJson photo : photos) {
-                CountryJson country = countryService.findById(photo.getCountryId());
-                usersPhoto.add(PhotoServiceJson.fromPhotoServiceJson(photo, country));
-            }
+        if (photos.isEmpty()) {
+            return new ArrayList<>();
         }
-        return usersPhoto;
+
+        return photos.stream()
+                .map(photo -> {
+                    CountryJson country = countryService.findById(photo.getCountryId());
+                    return PhotoServiceJson.fromPhotoServiceJson(photo, country);
+                })
+                .toList();
     }
 
     public PhotoJson editPhoto(PhotoJson photoJson, UUID id) {