Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support record component initializers #163

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Randgalt
Copy link
Owner

@Randgalt Randgalt commented Jan 2, 2024

New component annotation that specifies the name of either a public static final field or a public static method that will be used to initialize each record component in the generated builder so as to support default values.

Closes #110

@Randgalt Randgalt added this to the v39 milestone Jan 2, 2024
@Randgalt Randgalt mentioned this pull request Jan 2, 2024
@Randgalt Randgalt force-pushed the jordanz/support-initializers branch 5 times, most recently from 1f3ab21 to 0d5e3c9 Compare January 3, 2024 09:35
New component annotation that specifies the name of either
a public static final field or a public static method that will be
used to initialize each record component in the generated builder
so as to support default values.

Closes #110
@Randgalt Randgalt force-pushed the jordanz/support-initializers branch from 0d5e3c9 to be32ef3 Compare January 4, 2024 12:31
@Randgalt
Copy link
Owner Author

Randgalt commented Jan 4, 2024

@mads-b @pragmasoft-ua @agentgt any comments before I merge?

@agentgt
Copy link

agentgt commented Jan 4, 2024

LGTM. You addressed my concerns of external defaults nicely.

@Randgalt Randgalt merged commit d228666 into master Jan 5, 2024
2 checks passed
@Randgalt Randgalt deleted the jordanz/support-initializers branch January 5, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defaults
2 participants