Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled NaN validation in Weather Calculator #1977

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

dpgaharwal
Copy link
Contributor

@dpgaharwal dpgaharwal commented Jan 7, 2025

Fixes Issue🛠️

Closes #1969

Description👨‍💻

Added a popup functionality to handle cases where no input is provided, replacing NaN outputs with a user-friendly alert message prompting input.

Type of Change📄

  • Bug fix (non-breaking change which fixes a bug)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

image


Please assign under SWOC '25...

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 730121b
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/677ccc9c94ddf60008bf31df
😎 Deploy Preview https://deploy-preview-1977--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dpgaharwal, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100 Rakesh9100 changed the title Add validation to input Handled NaN validation in Weather Calculator Jan 7, 2025
@Rakesh9100 Rakesh9100 merged commit a66ed83 into Rakesh9100:main Jan 7, 2025
5 checks passed
Copy link

github-actions bot commented Jan 7, 2025

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @dpgaharwal

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion SWOC SWOC Open Source Program Intermediate Intermediate level task labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Intermediate Intermediate level task SWOC SWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Handle NaN validation in Weather Calculator
2 participants