Fixes related to the taint issue in DF pre-patch #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…We need to abort calling functions we know will cause insecure calls and break things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes to UI elements, previous checks to avoid purposefully causing taint issues failed.
The code has been centralized and a utility function has been made to narrow down the spread of the issue to ensure the entire addon respects secure frames that can not be touched by any addon, unless we wish taint and breaking issues like we are experiencing.
Once internal testing finishes, this will be merged into the main branch. Feel free to join and test this branch if you experienced issues but would like to check and see that the issue has been resolved with these code changes.
Relevant issues that are affected by this PR: