Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally generate boilerplate for UART console #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rahix
Copy link
Owner

@Rahix Rahix commented May 3, 2023

I'm very unsure where we should go this route, but I want to at least raise the possibility.

This PR adds a new prompt during project generation which asks the user whether they want additional boilerplate for a UART console in their project. This can of course be extended for other devices like I2C, SPI, panic handlers, etc.

One one hand, it would make starting a new project a bit faster. On the other, it means additional effort to keep the template up-to-date and has the chance of people just enabling everything "because maybe I'll need it" and then leaving the code sitting in their project unused. Not sure if we want to enable that...

In any case, I think this PR needs to wait until cargo-generate/cargo-generate#885 is resolved.

@brainstorm
Copy link

brainstorm commented Apr 1, 2024

On the one hand I agree that putting in too much lines of code is not neat, but on the other hand I think that it'd instantly solve issues like mine because it's a tested template?

I.e: Rahix/avr-hal#530

@Rahix
Copy link
Owner Author

Rahix commented Apr 1, 2024

For instance, I'm confused with the Usart+ufmt behavior on my Atmega2560, see this output in the commit message: brainstorm/embassy-as5600@a37b9b5

Please ask about this in the Discussions of avr-hal, then we can take a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants